Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84e4794a authored by Gaosheng Cui's avatar Gaosheng Cui Committed by Greg Kroah-Hartman
Browse files

crypto: img-hash - Fix variable dereferenced before check 'hdev->req' 



[ Upstream commit 04ba54e5af8f8f0137b08cb51a0b3a2e1ea46c94 ]

Smatch report warning as follows:

drivers/crypto/img-hash.c:366 img_hash_dma_task() warn: variable
dereferenced before check 'hdev->req'

Variable dereferenced should be done after check 'hdev->req',
fix it.

Fixes: d358f1ab ("crypto: img-hash - Add Imagination Technologies hw hash accelerator")
Fixes: 10badea2 ("crypto: img-hash - Fix null pointer exception")
Signed-off-by: default avatarGaosheng Cui <cuigaosheng1@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 36ffa816

drivers/crypto/img-hash.c

+6 −2
Original line number Diff line number Diff line
@@ -359,12 +359,16 @@ static int img_hash_dma_init(struct img_hash_dev *hdev) 
static void img_hash_dma_task(unsigned long d)

{

	struct img_hash_dev *hdev = (struct img_hash_dev *)d;

	struct img_hash_request_ctx *ctx = ahash_request_ctx(hdev->req);

	struct img_hash_request_ctx *ctx;

	u8 *addr;

	size_t nbytes, bleft, wsend, len, tbc;

	struct scatterlist tsg;



	if (!hdev->req || !ctx->sg)

	if (!hdev->req)

		return;



	ctx = ahash_request_ctx(hdev->req);

	if (!ctx->sg)

		return;



	addr = sg_virt(ctx->sg);