Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8340870c authored by Yuanyuan Liu's avatar Yuanyuan Liu
Browse files

icnss: Remove sending uevent after FW ready 



FW ready indication doesn't mean it is safe to access HW register.
FW ready only means that WLAN FW is initialized. The HW register
is safe to access only after FW ack the wlan enable mode request.
Hence removing uevent in FW ready indication handler. WLAN driver
will responsible for setting FW ready state once wlan enable mode
request is return success.

CRs-Fixed: 2168628
Change-Id: I769d848efb9dd427da0d71494090fcbf9514cfb2
Signed-off-by: default avatarYuanyuan Liu <yuanliu@codeaurora.org>
parent 436b6888

drivers/soc/qcom/icnss.c

+1 −3
Original line number Diff line number Diff line 
/* Copyright (c) 2015-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -2257,8 +2257,6 @@ static int icnss_driver_event_fw_ready_ind(void *data) 


	set_bit(ICNSS_FW_READY, &penv->state);



	icnss_call_driver_uevent(penv, ICNSS_UEVENT_FW_READY, NULL);



	icnss_pr_info("WLAN FW is ready: 0x%lx\n", penv->state);



	icnss_hw_power_off(penv);

include/soc/qcom/icnss.h

+1 −2
Original line number Diff line number Diff line 
/* Copyright (c) 2015-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -23,7 +23,6 @@ 
#endif



enum icnss_uevent {

	ICNSS_UEVENT_FW_READY,

	ICNSS_UEVENT_FW_CRASHED,

	ICNSS_UEVENT_FW_DOWN,

};