Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 830379e0 authored by Felipe Balbi's avatar Felipe Balbi Committed by Grant Likely
Browse files

spi/omap2: disable DMA requests before complete() 



No actual errors have been found for completing
before disabling DMA request lines, but it just
looks more semantically correct that on our DMA
callback we quiesce the whole thing before stating
transfer is finished.

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
parent 88b62b91

drivers/spi/spi-omap2-mcspi.c

+4 −4
Original line number Diff line number Diff line
@@ -298,10 +298,10 @@ static void omap2_mcspi_rx_callback(void *data) 
	struct omap2_mcspi *mcspi = spi_master_get_devdata(spi->master);

	struct omap2_mcspi_dma *mcspi_dma = &mcspi->dma_channels[spi->chip_select];



	complete(&mcspi_dma->dma_rx_completion);



	/* We must disable the DMA RX request */

	omap2_mcspi_set_dma_req(spi, 1, 0);



	complete(&mcspi_dma->dma_rx_completion);

}



static void omap2_mcspi_tx_callback(void *data)
@@ -310,10 +310,10 @@ static void omap2_mcspi_tx_callback(void *data) 
	struct omap2_mcspi *mcspi = spi_master_get_devdata(spi->master);

	struct omap2_mcspi_dma *mcspi_dma = &mcspi->dma_channels[spi->chip_select];



	complete(&mcspi_dma->dma_tx_completion);



	/* We must disable the DMA TX request */

	omap2_mcspi_set_dma_req(spi, 0, 0);



	complete(&mcspi_dma->dma_tx_completion);

}



static void omap2_mcspi_tx_dma(struct spi_device *spi,