Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82ee3e6f authored by Adrian Bunk's avatar Adrian Bunk Committed by Linus Torvalds
Browse files

[PATCH] drivers/media/video/tveeprom.c: possible cleanups 



This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 9e00e486

drivers/media/video/tveeprom.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -445,6 +445,7 @@ int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len) 
}

}

EXPORT_SYMBOL(tveeprom_read);

EXPORT_SYMBOL(tveeprom_read);





#if 0

int tveeprom_dump(unsigned char *eedata, int len)

int tveeprom_dump(unsigned char *eedata, int len)

{

{

	int i;

	int i;
@@ -460,6 +461,7 @@ int tveeprom_dump(unsigned char *eedata, int len) 
	return 0;

	return 0;

}

}

EXPORT_SYMBOL(tveeprom_dump);

EXPORT_SYMBOL(tveeprom_dump);

#endif  /*  0  */





/* ----------------------------------------------------------------------- */

/* ----------------------------------------------------------------------- */

/* needed for ivtv.sf.net at the moment.  Should go away in the long       */

/* needed for ivtv.sf.net at the moment.  Should go away in the long       */
@@ -477,7 +479,7 @@ static unsigned short normal_i2c[] = { 




I2C_CLIENT_INSMOD;

I2C_CLIENT_INSMOD;





struct i2c_driver i2c_driver_tveeprom;

static struct i2c_driver i2c_driver_tveeprom;





static int

static int

tveeprom_command(struct i2c_client *client,

tveeprom_command(struct i2c_client *client,
@@ -549,7 +551,7 @@ tveeprom_detach_client (struct i2c_client *client) 
	return 0;

	return 0;

}

}





struct i2c_driver i2c_driver_tveeprom = {

static struct i2c_driver i2c_driver_tveeprom = {

	.owner          = THIS_MODULE,

	.owner          = THIS_MODULE,

	.name           = "tveeprom",

	.name           = "tveeprom",

	.id             = I2C_DRIVERID_TVEEPROM,

	.id             = I2C_DRIVERID_TVEEPROM,

include/media/tveeprom.h

+0 −1
Original line number Original line Diff line number Diff line
@@ -24,4 +24,3 @@ void tveeprom_hauppauge_analog(struct tveeprom *tvee, 
			       unsigned char *eeprom_data);

			       unsigned char *eeprom_data);





int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
 
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
 
int tveeprom_dump(unsigned char *eedata, int len);