Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 827afdf0 authored by Adrian Bunk's avatar Adrian Bunk Committed by Linus Torvalds
Browse files

n_hdlc.c: fix check-after-use 



The Coverity checker spotted that we'd have already oops'ed if "tty"
was NULL.

Since "tty" can't be NULL when we reach this line of code this patch
removes the NULL check.

Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cba4fbbf

drivers/char/n_hdlc.c

+1 −1
Original line number Diff line number Diff line
@@ -229,7 +229,7 @@ static void n_hdlc_release(struct n_hdlc *n_hdlc) 
	wake_up_interruptible (&tty->read_wait);

	wake_up_interruptible (&tty->write_wait);



	if (tty != NULL && tty->disc_data == n_hdlc)

	if (tty->disc_data == n_hdlc)

		tty->disc_data = NULL;	/* Break the tty->n_hdlc link */



	/* Release transmit and receive buffers */