Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81abaab5 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map 



commit 4b32e054335ea0ce50967f63a7bfd4db058b14b9 upstream.

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak."

Fixes: c2f6d059 ("pinctrl: nomadik: refactor DT parser to take two paths")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220607111602.57355-1-linmq006@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6d8453df

drivers/pinctrl/nomadik/pinctrl-nomadik.c

+3 −1
Original line number Diff line number Diff line
@@ -1455,8 +1455,10 @@ static int nmk_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, 


	has_config = nmk_pinctrl_dt_get_config(np, &configs);

	np_config = of_parse_phandle(np, "ste,config", 0);

	if (np_config)

	if (np_config) {

		has_config |= nmk_pinctrl_dt_get_config(np_config, &configs);

		of_node_put(np_config);

	}

	if (has_config) {

		const char *gpio_name;

		const char *pin;