Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80ffb3cc authored by NeilBrown's avatar NeilBrown
Browse files

Fix new incorrect error return from do_md_stop.



Recent commit c8c00a69
changed the exit paths in do_md_stop and was not quite
careful enough.  There is one path were 'err' now needs
to be cleared but it isn't.
So setting an array to readonly (with mdadm --readonly) will
work, but will incorrectly report and error: ENXIO.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 4d484a4a
Loading
Loading
Loading
Loading
+1 −0
Original line number Original line Diff line number Diff line
@@ -4364,6 +4364,7 @@ static int do_md_stop(mddev_t * mddev, int mode, int is_open)
		if (mode == 1)
		if (mode == 1)
			set_disk_ro(disk, 1);
			set_disk_ro(disk, 1);
		clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
		clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
		err = 0;
	}
	}
out:
out:
	mutex_unlock(&mddev->open_mutex);
	mutex_unlock(&mddev->open_mutex);