Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80928805 authored by Steve Glendinning's avatar Steve Glendinning Committed by David S. Miller
Browse files

smsc95xx: set MII_BUSY bit to read/write PHY regs 



The device datasheet specifies the BUSY bit must be set when reading
or writing phy registers.  This patch ensures we do that.

Signed-off-by: default avatarSteve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0c9f79be

drivers/net/usb/smsc95xx.c

+2 −2
Original line number Diff line number Diff line
@@ -184,7 +184,7 @@ static int smsc95xx_mdio_read(struct net_device *netdev, int phy_id, int idx) 
	/* set the address, index & direction (read from PHY) */

	phy_id &= dev->mii.phy_id_mask;

	idx &= dev->mii.reg_num_mask;

	addr = (phy_id << 11) | (idx << 6) | MII_READ_;

	addr = (phy_id << 11) | (idx << 6) | MII_READ_ | MII_BUSY_;

	ret = smsc95xx_write_reg(dev, MII_ADDR, addr);

	check_warn_goto_done(ret, "Error writing MII_ADDR");
@@ -221,7 +221,7 @@ static void smsc95xx_mdio_write(struct net_device *netdev, int phy_id, int idx, 
	/* set the address, index & direction (write to PHY) */

	phy_id &= dev->mii.phy_id_mask;

	idx &= dev->mii.reg_num_mask;

	addr = (phy_id << 11) | (idx << 6) | MII_WRITE_;

	addr = (phy_id << 11) | (idx << 6) | MII_WRITE_ | MII_BUSY_;

	ret = smsc95xx_write_reg(dev, MII_ADDR, addr);

	check_warn_goto_done(ret, "Error writing MII_ADDR");