Commit 7f63d978 authored Apr 21, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman May 12, 2022

clk: sunxi: sun9i-mmc: check return value after calling platform_get_resource()



[ Upstream commit f58ca215cda1975f77b2b762903684a3c101bec9 ]

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Fixes: 7a6fca87 ("clk: sunxi: Add driver for A80 MMC config clocks/resets")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20220421134308.2885094-1-yangyingliang@huawei.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7361ca9c

drivers/clk/sunxi/clk-sun9i-mmc.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -117,6 +117,8 @@ static int sun9i_a80_mmc_config_clk_probe(struct platform_device *pdev)
	spin_lock_init(&data->lock);		spin_lock_init(&data->lock);

	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);		r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
			if (!r)
			return -EINVAL;
	/* one clock/reset pair per word */		/* one clock/reset pair per word */
	count = DIV_ROUND_UP((resource_size(r)), SUN9I_MMC_WIDTH);		count = DIV_ROUND_UP((resource_size(r)), SUN9I_MMC_WIDTH);
	data->membase = devm_ioremap_resource(&pdev->dev, r);		data->membase = devm_ioremap_resource(&pdev->dev, r);