Commit 7f52f314 authored Dec 04, 2015 by Dan Carpenter Committed by Bjorn Helgaas Dec 04, 2015

PCI: altera: Fix loop in tlp_read_packet()



TLP_LOOP is 500 and the "loop" variable was a u8 so "loop < TLP_LOOP" is
always true.  We only need this condition to work if there is a problem so
it would have been easy to miss this in testing.

Make it a normal for loop with "int i" instead of over thinking things and
making it complicated.

Fixes: 6bb4dd154ae8 ("PCI: altera: Add Altera PCIe host controller driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Ley Foon Tan <lftan@altera.com>

parent 3845d295

drivers/pci/host/pcie-altera.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -166,7 +166,7 @@ static bool altera_pcie_valid_config(struct altera_pcie *pcie,

		static int tlp_read_packet(struct altera_pcie pcie, u32 value)
		{
		u8 loop;
		int i;
		bool sop = 0;
		u32 ctrl;
		u32 reg0, reg1;
		@@ -175,7 +175,7 @@ static int tlp_read_packet(struct altera_pcie pcie, u32 value)
		* Minimum 2 loops to read TLP headers and 1 loop to read data
		* payload.
		*/
		for (loop = 0; loop < TLP_LOOP; loop++) {
		for (i = 0; i < TLP_LOOP; i++) {
		ctrl = cra_readl(pcie, RP_RXCPL_STATUS);
		if ((ctrl & RP_RXCPL_SOP) \|\| (ctrl & RP_RXCPL_EOP) \|\| sop) {
		reg0 = cra_readl(pcie, RP_RXCPL_REG0);