Commit 7f3aa14c authored Aug 26, 2020 by Vasundhara Volam Committed by Greg Kroah-Hartman Sep 12, 2020

bnxt_en: Check for zero dir entries in NVRAM.



[ Upstream commit dbbfa96ad920c50d58bcaefa57f5f33ceef9d00e ]

If firmware goes into unstable state, HWRM_NVM_GET_DIR_INFO firmware
command may return zero dir entries. Return error in such case to
avoid zero length dma buffer request.

Fixes: c0c050c5 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8064eaf3

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1457,6 +1457,9 @@ static int bnxt_get_nvram_directory(struct net_device dev, u32 len, u8 data)
		if (rc != 0)
		return rc;

		if (!dir_entries \|\| !entry_length)
		return -EIO;

		/* Insert 2 bytes of directory info (count and size of entries) */
		if (len < 2)
		return -EINVAL;