Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ee34ab2 authored by Devendra Naga's avatar Devendra Naga Committed by Greg Kroah-Hartman
Browse files

staging: slicoss: release firmware before returning 



we request_firmware in slic_card_download_gbrcv and we return out
with out calling release_firmware, where we compare against a
firmware lengths of certain device ids.

Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 651d4bc7

drivers/staging/slicoss/slicoss.c

+6 −2
Original line number Diff line number Diff line
@@ -528,12 +528,16 @@ static int slic_card_download_gbrcv(struct adapter *adapter) 
	index += 4;

	switch (adapter->devid) {

	case SLIC_2GB_DEVICE_ID:

		if (rcvucodelen != OasisRcvUCodeLen)

		if (rcvucodelen != OasisRcvUCodeLen) {

			release_firmware(fw);

			return -EINVAL;

		}

		break;

	case SLIC_1GB_DEVICE_ID:

		if (rcvucodelen != GBRcvUCodeLen)

		if (rcvucodelen != GBRcvUCodeLen) {

			release_firmware(fw);

			return -EINVAL;

		}

		break;

	default:

		ASSERT(0);