Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e1b2b2d authored by Stephan Mueller's avatar Stephan Mueller Committed by Greg Kroah-Hartman
Browse files

crypto: drbg - fix freeing of resources 



commit bd6227a150fdb56e7bb734976ef6e53a2c1cb334 upstream.

During the change to use aligned buffers, the deallocation code path was
not updated correctly. The current code tries to free the aligned buffer
pointer and not the original buffer pointer as it is supposed to.

Thus, the code is updated to free the original buffer pointer and set
the aligned buffer pointer that is used throughout the code to NULL.

Fixes: 3cfc3b97 ("crypto: drbg - use aligned buffers")
CC: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarStephan Mueller <smueller@chronox.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 29825768

crypto/drbg.c

+4 −4
Original line number Diff line number Diff line
@@ -1133,10 +1133,10 @@ static inline void drbg_dealloc_state(struct drbg_state *drbg) 
{

	if (!drbg)

		return;

	kzfree(drbg->V);

	drbg->Vbuf = NULL;

	kzfree(drbg->C);

	drbg->Cbuf = NULL;

	kzfree(drbg->Vbuf);

	drbg->V = NULL;

	kzfree(drbg->Cbuf);

	drbg->C = NULL;

	kzfree(drbg->scratchpadbuf);

	drbg->scratchpadbuf = NULL;

	drbg->reseed_ctr = 0;