Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7df4a691 authored by Mark Hills's avatar Mark Hills Committed by Takashi Iwai
Browse files

ALSA: usb-audio: Fix comment 



Explained by Takashi in <s5hfwbtmz0q.wl%tiwai@suse.de>

> The reason is because get_min_max*() isn't called in the place you
> created these controls, and get_min_max() would be called only for
> integer volumes later even if uninitialized.  A short cut for booleans.

Signed-off-by: default avatarMark Hills <mark@pogo.org.uk>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0910c216

sound/usb/mixer_quirks.c

+2 −10
Original line number Diff line number Diff line
@@ -79,16 +79,8 @@ static int snd_create_std_mono_ctl(struct usb_mixer_interface *mixer, 
	cval->control = control;

	cval->cmask = cmask;



	/* FIXME: Do we need this?

	 * The following values are for compatibility with

	 * Ebox-44 mixer.

	 * But the corresponding ebox-44 function says:

	 *    "Volume controls will override these values"

	 *

	 * These values don't have any effect at all for

	 * M-Audio FTUs.

	 * So I think, we can safely omit the range settings here.

	 */

	/* get_min_max() is called only for integer volumes later,

	 * so provide a short-cut for booleans */

	cval->min = 0;

	cval->max = 1;

	cval->res = 0;