Commit 7b5f260f authored Mar 16, 2019 by Eric Dumazet Committed by Greg Kroah-Hartman Apr 03, 2019

tun: add a missing rcu_read_unlock() in error path



commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream.

In my latest patch I missed one rcu_read_unlock(), in case
device is down.

Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6f0f3657

drivers/net/tun.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1330,6 +1330,7 @@ static ssize_t tun_get_user(struct tun_struct tun, struct tun_file tfile,
		rcu_read_lock();
		if (unlikely(!(tun->dev->flags & IFF_UP))) {
		err = -EIO;
		rcu_read_unlock();
		goto drop;
		}