Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b3bb0e7 authored by Chunyan Zhang's avatar Chunyan Zhang Committed by Greg Kroah-Hartman
Browse files

stm class: Fix an off-by-one in master array allocation 



Since both sw_start and sw_end are master indices, the size of array
that holds them is sw_end - sw_start + 1, which the current code gets
wrong, allocating one item less than required.

This patch corrects the allocation size, avoiding potential slab
corruption.

Signed-off-by: default avatarChunyan Zhang <zhang.chunyan@linaro.org>
[alexander.shishkin@linux.intel.com: re-wrote the commit message]
Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c74f7e82

drivers/hwtracing/stm/core.c

+1 −1
Original line number Diff line number Diff line
@@ -618,7 +618,7 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data, 
	if (!stm_data->packet || !stm_data->sw_nchannels)

		return -EINVAL;



	nmasters = stm_data->sw_end - stm_data->sw_start;

	nmasters = stm_data->sw_end - stm_data->sw_start + 1;

	stm = kzalloc(sizeof(*stm) + nmasters * sizeof(void *), GFP_KERNEL);

	if (!stm)

		return -ENOMEM;