Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a9a7b77 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: Fix a module reference issue in rpcsec_gss 



We're not taking a reference in the case where _gss_mech_get_by_pseudoflavor
loops without finding the correct rpcsec_gss flavour, so why are we
releasing it?

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 1f2edbe3

net/sunrpc/auth_gss/gss_mech_switch.c

+1 −3
Original line number Diff line number Diff line
@@ -218,10 +218,8 @@ static struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor) 


	spin_lock(&registered_mechs_lock);

	list_for_each_entry(pos, &registered_mechs, gm_list) {

		if (!mech_supports_pseudoflavor(pos, pseudoflavor)) {

			module_put(pos->gm_owner);

		if (!mech_supports_pseudoflavor(pos, pseudoflavor))

			continue;

		}

		if (try_module_get(pos->gm_owner))

			gm = pos;

		break;