Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79b17a94 authored by Dmitry Kravkov's avatar Dmitry Kravkov Committed by David S. Miller
Browse files

bnx2x: Consider DCBX remote error 



When publishing information via getfeatcfg(), bnx2x driver didn't consider
remote errors (e.g., switch that doesn't support DCBX) when setting the
error flags.

Signed-off-by: default avatarDmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: default avatarYuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: default avatarAriel Elior <ariele@broadcom.com>
Signed-off-by: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 07b4eb3b

drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c

+6 −3
Original line number Diff line number Diff line
@@ -2391,21 +2391,24 @@ static u8 bnx2x_dcbnl_get_featcfg(struct net_device *netdev, int featid, 
		case DCB_FEATCFG_ATTR_PG:

			if (bp->dcbx_local_feat.ets.enabled)

				*flags |= DCB_FEATCFG_ENABLE;

			if (bp->dcbx_error & DCBX_LOCAL_ETS_ERROR)

			if (bp->dcbx_error & (DCBX_LOCAL_ETS_ERROR |

					      DCBX_REMOTE_MIB_ERROR))

				*flags |= DCB_FEATCFG_ERROR;

			break;

		case DCB_FEATCFG_ATTR_PFC:

			if (bp->dcbx_local_feat.pfc.enabled)

				*flags |= DCB_FEATCFG_ENABLE;

			if (bp->dcbx_error & (DCBX_LOCAL_PFC_ERROR |

			    DCBX_LOCAL_PFC_MISMATCH))

					      DCBX_LOCAL_PFC_MISMATCH |

					      DCBX_REMOTE_MIB_ERROR))

				*flags |= DCB_FEATCFG_ERROR;

			break;

		case DCB_FEATCFG_ATTR_APP:

			if (bp->dcbx_local_feat.app.enabled)

				*flags |= DCB_FEATCFG_ENABLE;

			if (bp->dcbx_error & (DCBX_LOCAL_APP_ERROR |

			    DCBX_LOCAL_APP_MISMATCH))

					      DCBX_LOCAL_APP_MISMATCH |

					      DCBX_REMOTE_MIB_ERROR))

				*flags |= DCB_FEATCFG_ERROR;

			break;

		default: