Commit 79960943 authored Nov 15, 2015 by David Gstir Committed by Herbert Xu Nov 16, 2015

crypto: talitos - Fix timing leak in ESP ICV verification



Using non-constant time memcmp() makes the verification of the authentication
tag in the decrypt path vulnerable to timing attacks. Fix this by using
crypto_memneq() instead.

Cc: stable@vger.kernel.org
Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent cb8affb5

drivers/crypto/talitos.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -977,7 +977,7 @@ static void ipsec_esp_decrypt_swauth_done(struct device *dev,
		} else
		oicv = (char *)&edesc->link_tbl[0];

		err = memcmp(oicv, icv, authsize) ? -EBADMSG : 0;
		err = crypto_memneq(oicv, icv, authsize) ? -EBADMSG : 0;
		}

		kfree(edesc);