Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 795c9baa authored by Noralf Trønnes's avatar Noralf Trønnes Committed by Gerrit - the friendly Code Review server
Browse files

drm/client: Rename drm_client_add() to drm_client_register() 



This is done to stay consistent with our naming scheme of
_register() = others can start calling us from any thread.

Suggested-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190403125658.32389-1-noralf@tronnes.org


Patch-mainline: 20190403125658.32389-1-noralf@tronnes.org @ 03/04/19, 12:56 p.m.
[stalek@codeaurora.org: drop changes for drm_fb_helper.c as
the existing changes are not present.]

Change-Id: Ib33fe6d4e8a7ed056d5b97a2da0dbd61b23897f2
Signed-off-by: default avatarShubham Talekar <stalek@codeaurora.org>
parent a011ebdf

drivers/gpu/drm/drm_client.c

+6 −5
Original line number Diff line number Diff line
@@ -64,7 +64,8 @@ EXPORT_SYMBOL(drm_client_close); 
 * @name: Client name

 * @funcs: DRM client functions (optional)

 *

 * This initialises the client and opens a &drm_file. Use drm_client_add() to complete the process.

 * This initialises the client and opens a &drm_file.

 * Use drm_client_register() to complete the process.

 * The caller needs to hold a reference on @dev before calling this function.

 * The client is freed when the &drm_device is unregistered. See drm_client_release().

 *
@@ -104,16 +105,16 @@ int drm_client_init(struct drm_device *dev, struct drm_client_dev *client, 
EXPORT_SYMBOL(drm_client_init);



/**

 * drm_client_add - Add client to the device list

 * drm_client_register - Register client

 * @client: DRM client

 *

 * Add the client to the &drm_device client list to activate its callbacks.

 * @client must be initialized by a call to drm_client_init(). After

 * drm_client_add() it is no longer permissible to call drm_client_release()

 * drm_client_register() it is no longer permissible to call drm_client_release()

 * directly (outside the unregister callback), instead cleanup will happen

 * automatically on driver unload.

 */

void drm_client_add(struct drm_client_dev *client)

void drm_client_register(struct drm_client_dev *client)

{

	struct drm_device *dev = client->dev;
@@ -121,7 +122,7 @@ void drm_client_add(struct drm_client_dev *client) 
	list_add(&client->list, &dev->clientlist);

	mutex_unlock(&dev->clientlist_mutex);

}

EXPORT_SYMBOL(drm_client_add);

EXPORT_SYMBOL(drm_client_register);



/**

 * drm_client_release - Release DRM client resources

include/drm/drm_client.h

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ struct drm_client_dev { 


int drm_client_init(struct drm_device *dev, struct drm_client_dev *client,

		   const char *name, const struct drm_client_funcs *funcs);

void drm_client_add(struct drm_client_dev *client);

void drm_client_register(struct drm_client_dev *client);



void drm_client_dev_unregister(struct drm_device *dev);

void drm_client_dev_hotplug(struct drm_device *dev);