Commit 78b7b80c authored Nov 13, 2015 by Dan Carpenter Committed by Martin K. Petersen Nov 13, 2015

mvsas: don't allow negative timeouts



There is a static checker warning here because "val" is controlled by
the user and we have a upper bound on it but allow negative numbers.
"val" appears to be a timeout in usec so this bug probably means we
have a longer timeout than we should.  Let's fix this by changing "val"
to unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 15de0de2

drivers/scsi/mvsas/mv_init.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -759,7 +759,7 @@ mvs_store_interrupt_coalescing(struct device *cdev,
		struct device_attribute *attr,
		const char *buffer, size_t size)
		{
		int val = 0;
		unsigned int val = 0;
		struct mvs_info *mvi = NULL;
		struct Scsi_Host *shost = class_to_shost(cdev);
		struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);
		@@ -767,7 +767,7 @@ mvs_store_interrupt_coalescing(struct device *cdev,
		if (buffer == NULL)
		return size;

		if (sscanf(buffer, "%d", &val) != 1)
		if (sscanf(buffer, "%u", &val) != 1)
		return -EINVAL;

		if (val >= 0x10000) {