Commit 77032ca6 authored Nov 24, 2015 by Eric Sandeen Committed by Jens Axboe Nov 25, 2015

Return EBUSY from BLKRRPART for mounted whole-dev fs



Today, blockdev --rereadpt /dev/sda will fail with EBUSY if any
partition of sda is mounted (and will fail with EINVAL if pointed
at a partition).  But it will pass if the entire block device is
formatted with a filesystem and mounted.  I don't think this makes
sense; partitioning should surely not ever change out from under
a mounted device.

So check for bdev->bd_super, and fail that with -EBUSY as well.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 78c4a49a

block/partition-generic.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -397,7 +397,7 @@ static int drop_partitions(struct gendisk disk, struct block_device bdev)
		struct hd_struct *part;
		int res;

		if (bdev->bd_part_count)
		if (bdev->bd_part_count \|\| bdev->bd_super)
		return -EBUSY;
		res = invalidate_partition(disk, 0);
		if (res)