Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76e71460 authored by Cristian Birsan's avatar Cristian Birsan Committed by Greg Kroah-Hartman
Browse files

usb: gadget: udc: atmel: Fix interrupt storm in FIFO mode. 



[ Upstream commit ba3a1a915c49cc3023e4ddfc88f21e7514e82aa4 ]

Fix interrupt storm generated by endpoints when working in FIFO mode.
The TX_COMPLETE interrupt is used only by control endpoints processing.
Do not enable it for other types of endpoints.

Fixes: 914a3f3b ("USB: add atmel_usba_udc driver")
Signed-off-by: default avatarCristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 954d0564

drivers/usb/gadget/udc/atmel_usba_udc.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -403,8 +403,10 @@ static void submit_request(struct usba_ep *ep, struct usba_request *req) 
		next_fifo_transaction(ep, req);

		next_fifo_transaction(ep, req);

		if (req->last_transaction) {

		if (req->last_transaction) {

			usba_ep_writel(ep, CTL_DIS, USBA_TX_PK_RDY);

			usba_ep_writel(ep, CTL_DIS, USBA_TX_PK_RDY);

			if (ep_is_control(ep))

				usba_ep_writel(ep, CTL_ENB, USBA_TX_COMPLETE);

				usba_ep_writel(ep, CTL_ENB, USBA_TX_COMPLETE);

		} else {

		} else {

			if (ep_is_control(ep))

				usba_ep_writel(ep, CTL_DIS, USBA_TX_COMPLETE);

				usba_ep_writel(ep, CTL_DIS, USBA_TX_COMPLETE);

			usba_ep_writel(ep, CTL_ENB, USBA_TX_PK_RDY);

			usba_ep_writel(ep, CTL_ENB, USBA_TX_PK_RDY);

		}

		}