Commit 76aa65a2 authored Mar 14, 2017 by Bill Kuzeja Committed by Greg Kroah-Hartman May 14, 2017

scsi: qla2xxx: Fix crash in qla2xxx_eh_abort on bad ptr



commit 5f7c2beef819d9ea2d1b814edf6f5981420e9cf8 upstream.

After a Qlogic card breaks when initializing (test case), the system can
crash in qla2xxx_eh_abort if processing anything but a scsi command type
srb.

Fixes: 1535aa75 ("scsi: qla2xxx: fix invalid DMA access after command aborts in PCI device remove")
Signed-off-by: Bill Kuzeja <william.kuzeja@stratus.com>
Acked-By: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 71fd9a94

drivers/scsi/qla2xxx/qla_os.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1464,7 +1464,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res)
		/* Don't abort commands in adapter during EEH
		* recovery as it's not accessible/responding.
		*/
		if (GET_CMD_SP(sp) && !ha->flags.eeh_busy) {
		if (GET_CMD_SP(sp) && !ha->flags.eeh_busy &&
		(sp->type == SRB_SCSI_CMD)) {
		/* Get a reference to the sp and drop the lock.
		* The reference ensures this sp->done() call
		* - and not the call in qla2xxx_eh_abort() -