Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7655e594 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] af9015: Fix max I2C message size when used with tda18271 



Changeset 1724c8fa added an option to change
the maximum I2C size to 8 bytes. However, it forgot to replace the previous
usage at af9015 to use the newly defined macro value
(TDA18271_16_BYTE_CHUNK_INIT).

A latter changeset (e350d44f) extended the
possible values for .small_i2c field and, instead of using a random sequence
of numbers, it used a number that makes more sense (e. g. the actual limit,
in terms of bytes).

However, as af9015 were using .small_i2c = 1, this become undefined, and the
restriction of a max size of 16 was gone.

While here, fix the reported msg size at tda18271-common.c.

Reported-by: default avatarJiri Slaby <jirislaby@gmail.com>
Tested-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent dc697984

drivers/media/common/tuners/tda18271-common.c

+1 −1
Original line number Diff line number Diff line
@@ -237,7 +237,7 @@ int tda18271_write_regs(struct dvb_frontend *fe, int idx, int len) 


	if (ret != 1)

		tda_err("ERROR: idx = 0x%x, len = %d, "

			"i2c_transfer returned: %d\n", idx, len, ret);

			"i2c_transfer returned: %d\n", idx, max, ret);



	return (ret == 1 ? 0 : ret);

}

drivers/media/dvb/dvb-usb/af9015.c

+1 −1
Original line number Diff line number Diff line
@@ -1131,7 +1131,7 @@ static struct qt1010_config af9015_qt1010_config = { 


static struct tda18271_config af9015_tda18271_config = {

	.gate = TDA18271_GATE_DIGITAL,

	.small_i2c = 1,

	.small_i2c = TDA18271_16_BYTE_CHUNK_INIT,

};



static struct mxl5005s_config af9015_mxl5003_config = {