Commit 75d29713 authored Oct 12, 2016 by Dan Carpenter Committed by Dan Williams Oct 19, 2016

libnvdimm, namespace: potential NULL deref on allocation error



If the kcalloc() fails then "devs" can be NULL and we dereference it
checking "devs[i]".

Fixes: 1b40e09a ('libnvdimm: blk labels and namespace instantiation')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 1001354c

drivers/nvdimm/namespace_devs.c

+8 −6

Original line number	Diff line number	Diff line
		@@ -2176,12 +2176,14 @@ static struct device *scan_labels(struct nd_region nd_region)
		return devs;

		err:
		if (devs) {
		for (i = 0; devs[i]; i++)
		if (is_nd_blk(&nd_region->dev))
		namespace_blk_release(devs[i]);
		else
		namespace_pmem_release(devs[i]);
		kfree(devs);
		}
		return NULL;
		}