Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75cfe338 authored by Luca Coelho's avatar Luca Coelho
Browse files

iwlwifi: mvm: bail out if CTDP start operation fails 



We were assigning the return value of iwl_mvm_ctdp_command() to a
variable, but never checking it.  If this command fails, we should not
allow the interface up process to proceed, since it is potentially
dangerous to ignore thermal management requirements.

Fixes: commit 5c89e7bc ("iwlwifi: mvm: add registration to cooling device")
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent cc2f41f8

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

+4 −1
Original line number Diff line number Diff line
@@ -1233,9 +1233,12 @@ int iwl_mvm_up(struct iwl_mvm *mvm) 
	}



	/* TODO: read the budget from BIOS / Platform NVM */

	if (iwl_mvm_is_ctdp_supported(mvm) && mvm->cooling_dev.cur_state > 0)

	if (iwl_mvm_is_ctdp_supported(mvm) && mvm->cooling_dev.cur_state > 0) {

		ret = iwl_mvm_ctdp_command(mvm, CTDP_CMD_OPERATION_START,

					   mvm->cooling_dev.cur_state);

		if (ret)

			goto error;

	}

#else

	/* Initialize tx backoffs to the minimal possible */

	iwl_mvm_tt_tx_backoff(mvm, 0);