Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75ce3b1b authored by Harshitha Sai Neelati's avatar Harshitha Sai Neelati
Browse files

adreno_tz: Correct acc_relative_busy calculation 



Current acc_relative_busy calculation is causing integer overflow
in 32 bit system. "stats->busy_time * stats->current_frequency"
results in a value which is beyond the 32 bit range.

Typecasting the value to u64 to avoid overflow.

Change-Id: Id97da02bef608787ceb7c9751bbfc203af56deb1
Signed-off-by: default avatarHarshitha Sai Neelati <hsaine@codeaurora.org>
parent cc611d16

drivers/devfreq/governor_msm_adreno_tz.c

+7 −3
Original line number Diff line number Diff line 
/* Copyright (c) 2010-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2010-2017, 2019 The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -150,6 +150,8 @@ void compute_work_load(struct devfreq_dev_status *stats, 
		struct devfreq_msm_adreno_tz_data *priv,

		struct devfreq *devfreq)

{

	u64 busy;



	spin_lock(&sample_lock);

	/*

	 * Keep collecting the stats till the client
@@ -157,8 +159,10 @@ void compute_work_load(struct devfreq_dev_status *stats, 
	 * is done when the entry is read

	 */

	acc_total += stats->total_time;

	acc_relative_busy += (stats->busy_time * stats->current_frequency) /

				devfreq->profile->freq_table[0];

	busy = (u64)stats->busy_time * stats->current_frequency;

	do_div(busy, devfreq->profile->freq_table[0]);

	acc_relative_busy += busy;



	spin_unlock(&sample_lock);

}