Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75945896 authored by Bard Liao's avatar Bard Liao Committed by Mark Brown
Browse files

ASoC: rt5645: Fix potential crash in jd function 



If no one defined the rt5645->pdata.hp_det_gpio in coreboot/bios.
It will cause kernel to reboot because rt5645->pdata.hp_det_gpio
is 0. So it is worth to add a check in rt5645_jack_detect.

Signed-off-by: default avatarBard Liao <bardliao@realtek.com>
Signed-off-by: default avatarFang, Yang A <yang.a.fang@intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent df078d29

sound/soc/codecs/rt5645.c

+4 −0
Original line number Diff line number Diff line
@@ -2113,6 +2113,10 @@ static int rt5645_jack_detect(struct snd_soc_codec *codec, 
	int gpio_state, jack_type = 0;

	unsigned int val;



	if (!gpio_is_valid(rt5645->pdata.hp_det_gpio)) {

		dev_err(codec->dev, "invalid gpio\n");

		return -EINVAL;

	}

	gpio_state = gpio_get_value(rt5645->pdata.hp_det_gpio);



	dev_dbg(codec->dev, "gpio = %d(%d)\n", rt5645->pdata.hp_det_gpio,