Commit 74f20788 authored Jun 28, 2014 by Fabian Frederick Committed by Daniel Vetter Jul 18, 2014

drivers/gpu/drm/drm_buffer.c: remove unnecessary null test before kfree



This patch removes special case of last element and loops from idx to 0.

Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

parent 2aa9d2bc

drivers/gpu/drm/drm_buffer.c

+1 −5

Original line number	Original line	Diff line number	Diff line
	@@ -80,11 +80,7 @@ int drm_buffer_alloc(struct drm_buffer **buf, int size)

	error_out:		error_out:

	/* Only last element can be null pointer so check for it first. */		for (; idx >= 0; --idx)
	if ((*buf)->data[idx])
	kfree((*buf)->data[idx]);

	for (--idx; idx >= 0; --idx)
	kfree((*buf)->data[idx]);		kfree((*buf)->data[idx]);

	kfree(*buf);		kfree(*buf);