Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 740f14ba authored by Arnaud Patard's avatar Arnaud Patard Committed by Linus Torvalds
Browse files

[PATCH] s3c2410fb: cleanup and fix 



Here are some cleanups for the s3c2410fb drivers. It :
* Removes a buggy call to s3c2410fb_init_registers. There was two calls
  to this function but the first was done without all initialisations
  done. No oops but it may confuse some LCDs.
* Makes two functions static.

Signed-Off-By: default avatarArnaud Patard <arnaud.patard@rtp-net.org>
Signed-Off-By: default avatarAntonino Daplas <adaplas@pol.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 918799ab

drivers/video/s3c2410fb.c

+4 −6
Original line number Diff line number Diff line
@@ -552,7 +552,7 @@ static inline void modify_gpio(void __iomem *reg, 
 * s3c2410fb_init_registers - Initialise all LCD-related registers

 */



int s3c2410fb_init_registers(struct s3c2410fb_info *fbi)

static int s3c2410fb_init_registers(struct s3c2410fb_info *fbi)

{

	unsigned long flags;
@@ -634,7 +634,7 @@ static irqreturn_t s3c2410fb_irq(int irq, void *dev_id, struct pt_regs *r) 


static char driver_name[]="s3c2410fb";



int __init s3c2410fb_probe(struct platform_device *pdev)

static int __init s3c2410fb_probe(struct platform_device *pdev)

{

	struct s3c2410fb_info *info;

	struct fb_info	   *fbinfo;
@@ -667,8 +667,6 @@ int __init s3c2410fb_probe(struct platform_device *pdev) 
	info->fb = fbinfo;

	platform_set_drvdata(pdev, fbinfo);



	s3c2410fb_init_registers(info);



	dprintk("devinit\n");



	strcpy(fbinfo->fix.id, driver_name);