Commit 73b3a665 authored Nov 03, 2014 by Roger Quadros Committed by Tony Lindgren Nov 10, 2014

pinctrl: dra: dt-bindings: Fix output pull up/down



For PIN_OUTPUT_PULLUP and PIN_OUTPUT_PULLDOWN we must not set the
PULL_DIS bit which disables the PULLs.

PULL_ENA is a 0 and using it in an OR operation is a NOP, so don't
use it in the PIN_OUTPUT_PULLUP/DOWN macros.

Fixes: 23d9cec0 ("pinctrl: dra: dt-bindings: Fix pull enable/disable")

Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 05eb20fa

include/dt-bindings/pinctrl/dra.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -40,8 +40,8 @@

		/* Active pin states */
		#define PIN_OUTPUT (0 \| PULL_DIS)
		#define PIN_OUTPUT_PULLUP (PIN_OUTPUT \| PULL_ENA \| PULL_UP)
		#define PIN_OUTPUT_PULLDOWN (PIN_OUTPUT \| PULL_ENA)
		#define PIN_OUTPUT_PULLUP (PULL_UP)
		#define PIN_OUTPUT_PULLDOWN (0)
		#define PIN_INPUT (INPUT_EN \| PULL_DIS)
		#define PIN_INPUT_SLEW (INPUT_EN \| SLEWCONTROL)
		#define PIN_INPUT_PULLUP (PULL_ENA \| INPUT_EN \| PULL_UP)