Commit 73aea4ec authored Sep 13, 2005 by Neil Brown Committed by Linus Torvalds Sep 13, 2005

[PATCH] nfsd4: fix setclientid unlock of unlocked state lock



We could try to unlock the state lock here without having first locked it.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent b59e3c0e

fs/nfsd/nfs4state.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -678,13 +678,12 @@ nfsd4_setclientid(struct svc_rqst rqstp, struct nfsd4_setclientid setclid)
		int status;
		char dname[HEXDIR_LEN];

		status = nfserr_inval;
		if (!check_name(clname))
		goto out;
		return nfserr_inval;

		status = nfs4_make_rec_clidname(dname, &clname);
		if (status)
		goto out;
		return status;

		/*
		* XXX The Duplicate Request Cache (DRC) has been checked (??)