Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7334ef16 authored by Yang Guang's avatar Yang Guang Committed by Greg Kroah-Hartman
Browse files

scsi: bfa: Replace snprintf() with sysfs_emit() 

[ Upstream commit 2245ea91fd3a04cafbe2f54911432a8657528c3b ]

coccinelle report:
./drivers/scsi/bfa/bfad_attr.c:908:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:860:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:888:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:853:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:808:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:728:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:822:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:927:9-17:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:900:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:874:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:714:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/bfa/bfad_attr.c:839:8-16:
WARNING: use scnprintf or sprintf

Use sysfs_emit() instead of scnprintf() or sprintf().

Link: https://lore.kernel.org/r/def83ff75faec64ba592b867a8499b1367bae303.1643181468.git.yang.guang5@zte.com.cn


Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarYang Guang <yang.guang5@zte.com.cn>
Signed-off-by: default avatarDavid Yang <davidcomponentone@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 8dbbae59

drivers/scsi/bfa/bfad_attr.c

+13 −13
Original line number Diff line number Diff line
@@ -722,7 +722,7 @@ bfad_im_serial_num_show(struct device *dev, struct device_attribute *attr, 
	char serial_num[BFA_ADAPTER_SERIAL_NUM_LEN];



	bfa_get_adapter_serial_num(&bfad->bfa, serial_num);

	return snprintf(buf, PAGE_SIZE, "%s\n", serial_num);

	return sysfs_emit(buf, "%s\n", serial_num);

}



static ssize_t
@@ -736,7 +736,7 @@ bfad_im_model_show(struct device *dev, struct device_attribute *attr, 
	char model[BFA_ADAPTER_MODEL_NAME_LEN];



	bfa_get_adapter_model(&bfad->bfa, model);

	return snprintf(buf, PAGE_SIZE, "%s\n", model);

	return sysfs_emit(buf, "%s\n", model);

}



static ssize_t
@@ -816,7 +816,7 @@ bfad_im_model_desc_show(struct device *dev, struct device_attribute *attr, 
		snprintf(model_descr, BFA_ADAPTER_MODEL_DESCR_LEN,

			"Invalid Model");



	return snprintf(buf, PAGE_SIZE, "%s\n", model_descr);

	return sysfs_emit(buf, "%s\n", model_descr);

}



static ssize_t
@@ -830,7 +830,7 @@ bfad_im_node_name_show(struct device *dev, struct device_attribute *attr, 
	u64        nwwn;



	nwwn = bfa_fcs_lport_get_nwwn(port->fcs_port);

	return snprintf(buf, PAGE_SIZE, "0x%llx\n", cpu_to_be64(nwwn));

	return sysfs_emit(buf, "0x%llx\n", cpu_to_be64(nwwn));

}



static ssize_t
@@ -847,7 +847,7 @@ bfad_im_symbolic_name_show(struct device *dev, struct device_attribute *attr, 
	bfa_fcs_lport_get_attr(&bfad->bfa_fcs.fabric.bport, &port_attr);

	strlcpy(symname, port_attr.port_cfg.sym_name.symname,

			BFA_SYMNAME_MAXLEN);

	return snprintf(buf, PAGE_SIZE, "%s\n", symname);

	return sysfs_emit(buf, "%s\n", symname);

}



static ssize_t
@@ -861,14 +861,14 @@ bfad_im_hw_version_show(struct device *dev, struct device_attribute *attr, 
	char hw_ver[BFA_VERSION_LEN];



	bfa_get_pci_chip_rev(&bfad->bfa, hw_ver);

	return snprintf(buf, PAGE_SIZE, "%s\n", hw_ver);

	return sysfs_emit(buf, "%s\n", hw_ver);

}



static ssize_t

bfad_im_drv_version_show(struct device *dev, struct device_attribute *attr,

				char *buf)

{

	return snprintf(buf, PAGE_SIZE, "%s\n", BFAD_DRIVER_VERSION);

	return sysfs_emit(buf, "%s\n", BFAD_DRIVER_VERSION);

}



static ssize_t
@@ -882,7 +882,7 @@ bfad_im_optionrom_version_show(struct device *dev, 
	char optrom_ver[BFA_VERSION_LEN];



	bfa_get_adapter_optrom_ver(&bfad->bfa, optrom_ver);

	return snprintf(buf, PAGE_SIZE, "%s\n", optrom_ver);

	return sysfs_emit(buf, "%s\n", optrom_ver);

}



static ssize_t
@@ -896,7 +896,7 @@ bfad_im_fw_version_show(struct device *dev, struct device_attribute *attr, 
	char fw_ver[BFA_VERSION_LEN];



	bfa_get_adapter_fw_ver(&bfad->bfa, fw_ver);

	return snprintf(buf, PAGE_SIZE, "%s\n", fw_ver);

	return sysfs_emit(buf, "%s\n", fw_ver);

}



static ssize_t
@@ -908,7 +908,7 @@ bfad_im_num_of_ports_show(struct device *dev, struct device_attribute *attr, 
			(struct bfad_im_port_s *) shost->hostdata[0];

	struct bfad_s *bfad = im_port->bfad;



	return snprintf(buf, PAGE_SIZE, "%d\n",

	return sysfs_emit(buf, "%d\n",

			bfa_get_nports(&bfad->bfa));

}
@@ -916,7 +916,7 @@ static ssize_t 
bfad_im_drv_name_show(struct device *dev, struct device_attribute *attr,

				char *buf)

{

	return snprintf(buf, PAGE_SIZE, "%s\n", BFAD_DRIVER_NAME);

	return sysfs_emit(buf, "%s\n", BFAD_DRIVER_NAME);

}



static ssize_t
@@ -935,14 +935,14 @@ bfad_im_num_of_discovered_ports_show(struct device *dev, 
	rports = kzalloc(sizeof(struct bfa_rport_qualifier_s) * nrports,

			 GFP_ATOMIC);

	if (rports == NULL)

		return snprintf(buf, PAGE_SIZE, "Failed\n");

		return sysfs_emit(buf, "Failed\n");



	spin_lock_irqsave(&bfad->bfad_lock, flags);

	bfa_fcs_lport_get_rport_quals(port->fcs_port, rports, &nrports);

	spin_unlock_irqrestore(&bfad->bfad_lock, flags);

	kfree(rports);



	return snprintf(buf, PAGE_SIZE, "%d\n", nrports);

	return sysfs_emit(buf, "%d\n", nrports);

}



static          DEVICE_ATTR(serial_number, S_IRUGO,