Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72f49050 authored by Mike Frysinger's avatar Mike Frysinger Committed by David S. Miller
Browse files

netdev: bfin_mac: document TE setting in RMII modes 



The current code sometimes generates build warnings due to how it checks
the silicon revision, so clean it up and properly document things.

Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bc8d7da3

drivers/net/bfin_mac.c

+11 −2
Original line number Diff line number Diff line
@@ -1237,8 +1237,17 @@ static int bfin_mac_enable(struct phy_device *phydev) 


	if (phydev->interface == PHY_INTERFACE_MODE_RMII) {

		opmode |= RMII; /* For Now only 100MBit are supported */

#if (defined(CONFIG_BF537) || defined(CONFIG_BF536)) && CONFIG_BF_REV_0_2

#if defined(CONFIG_BF537) || defined(CONFIG_BF536)

		if (__SILICON_REVISION__ < 3) {

			/*

			 * This isn't publicly documented (fun times!), but in

			 * silicon <=0.2, the RX and TX pins are clocked together.

			 * So in order to recv, we must enable the transmit side

			 * as well.  This will cause a spurious TX interrupt too,

			 * but we can easily consume that.

			 */

			opmode |= TE;

		}

#endif

	}