Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72d282dc authored by Sachin Prabhu's avatar Sachin Prabhu Committed by Steve French
Browse files

cifs: Fix bug when checking error condition in cifs_rename_pending_delete() 



Fix check for error condition after setting attributes with
CIFSSMBSetFileInfo().

Signed-off-by: default avatarSachin Prabhu <sprabhu@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Reviewed-by: default avatarPavel Shilovsky <piastry@etersoft.ru>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 9f225788

fs/cifs/inode.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1023,7 +1023,7 @@ cifs_rename_pending_delete(const char *full_path, struct dentry *dentry, 
					current->tgid);

					current->tgid);

		/* although we would like to mark the file hidden

		/* although we would like to mark the file hidden

 		   if that fails we will still try to rename it */

 		   if that fails we will still try to rename it */

		if (rc != 0)

		if (!rc)

			cifsInode->cifsAttrs = dosattr;

			cifsInode->cifsAttrs = dosattr;

		else

		else

			dosattr = origattr; /* since not able to change them */

			dosattr = origattr; /* since not able to change them */