Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7275b4b6 authored by Antonino A. Daplas's avatar Antonino A. Daplas Committed by Linus Torvalds
Browse files

[PATCH] fbdev: Shift pixel value before entering loop in cfbimageblit 



In slow imageblit, the pixel value is shifted by a certain amount (dependent
on the bpp and endianness) for each iteration.  This is inefficient.  Better
do the shifting once before going into the loop.

Signed-off-by: default avatarAntonino Daplas <adaplas@pol.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 39942fd8

drivers/video/cfbimgblt.c

+2 −1
Original line number Diff line number Diff line
@@ -162,6 +162,8 @@ static inline void slow_imageblit(const struct fb_image *image, struct fb_info * 
	u32 i, j, l;

	

	dst2 = (u32 __iomem *) dst1;

	fgcolor <<= LEFT_POS(bpp);

	bgcolor <<= LEFT_POS(bpp);



	for (i = image->height; i--; ) {

		shift = val = 0;
@@ -180,7 +182,6 @@ static inline void slow_imageblit(const struct fb_image *image, struct fb_info * 
		while (j--) {

			l--;

			color = (*s & 1 << (BIT_NR(l))) ? fgcolor : bgcolor;

			color <<= LEFT_POS(bpp);

			val |= SHIFT_HIGH(color, shift);

			

			/* Did the bitshift spill bits to the next long? */