Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71aeeaa1 authored by Marcel Holtmann's avatar Marcel Holtmann
Browse files

Bluetooth: Reject incoming SCO connections without listeners 



All SCO and eSCO connection are auto-accepted no matter if there is a
corresponding listening socket for them. This patch changes this and
connection requests for SCO and eSCO without any socket are rejected.

Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent f66dc81f

net/bluetooth/sco.c

+22 −2
Original line number Diff line number Diff line
@@ -857,10 +857,30 @@ static void sco_conn_ready(struct sco_conn *conn) 
/* ----- SCO interface with lower layer (HCI) ----- */

static int sco_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 type)

{

	register struct sock *sk;

	struct hlist_node *node;

	int lm = 0;



	if (type != SCO_LINK && type != ESCO_LINK)

		return 0;



	BT_DBG("hdev %s, bdaddr %s", hdev->name, batostr(bdaddr));



	/* Always accept connection */

	return HCI_LM_ACCEPT;

	/* Find listening sockets */

	read_lock(&sco_sk_list.lock);

	sk_for_each(sk, node, &sco_sk_list.head) {

		if (sk->sk_state != BT_LISTEN)

			continue;



		if (!bacmp(&bt_sk(sk)->src, &hdev->bdaddr) ||

				!bacmp(&bt_sk(sk)->src, BDADDR_ANY)) {

			lm |= HCI_LM_ACCEPT;

			break;

		}

	}

	read_unlock(&sco_sk_list.lock);



	return lm;

}



static int sco_connect_cfm(struct hci_conn *hcon, __u8 status)