Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71ab8626 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

net: qrtr: Mark 'buf' as little endian 




[ Upstream commit 3512a1ad56174308a9fd3e10f4b1e3e152e9ec01 ]

Failure to mark this pointer as __le32 causes checkers like
sparse to complain:

net/qrtr/qrtr.c:274:16: warning: incorrect type in assignment (different base types)
net/qrtr/qrtr.c:274:16:    expected unsigned int [unsigned] [usertype] <noident>
net/qrtr/qrtr.c:274:16:    got restricted __le32 [usertype] <noident>
net/qrtr/qrtr.c:275:16: warning: incorrect type in assignment (different base types)
net/qrtr/qrtr.c:275:16:    expected unsigned int [unsigned] [usertype] <noident>
net/qrtr/qrtr.c:275:16:    got restricted __le32 [usertype] <noident>
net/qrtr/qrtr.c:276:16: warning: incorrect type in assignment (different base types)
net/qrtr/qrtr.c:276:16:    expected unsigned int [unsigned] [usertype] <noident>
net/qrtr/qrtr.c:276:16:    got restricted __le32 [usertype] <noident>

Silence it.

Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Acked-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c4081f91

net/qrtr/qrtr.c

+2 −2
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ static struct sk_buff *qrtr_alloc_resume_tx(u32 src_node, 
	const int pkt_len = 20;

	struct qrtr_hdr *hdr;

	struct sk_buff *skb;

	u32 *buf;

	__le32 *buf;



	skb = alloc_skb(QRTR_HDR_SIZE + pkt_len, GFP_KERNEL);

	if (!skb)
@@ -269,7 +269,7 @@ static struct sk_buff *qrtr_alloc_resume_tx(u32 src_node, 
	hdr->dst_node_id = cpu_to_le32(dst_node);

	hdr->dst_port_id = cpu_to_le32(QRTR_PORT_CTRL);



	buf = (u32 *)skb_put(skb, pkt_len);

	buf = (__le32 *)skb_put(skb, pkt_len);

	memset(buf, 0, pkt_len);

	buf[0] = cpu_to_le32(QRTR_TYPE_RESUME_TX);

	buf[1] = cpu_to_le32(src_node);