Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71755b12 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

i2c: xlr: Fix a resource leak in the error handling path of 'xlr_i2c_probe()' 



[ Upstream commit 7f98960c046ee1136e7096aee168eda03aef8a5d ]

A successful 'clk_prepare()' call should be balanced by a corresponding
'clk_unprepare()' call in the error handling path of the probe, as already
done in the remove function.

More specifically, 'clk_prepare_enable()' is used, but 'clk_disable()' is
also already called. So just the unprepare step has still to be done.

Update the error handling path accordingly.

Fixes: 75d31c23 ("i2c: xlr: add support for Sigma Designs controller variant")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5ac3a634

drivers/i2c/busses/i2c-xlr.c

+5 −1
Original line number Diff line number Diff line
@@ -434,11 +434,15 @@ static int xlr_i2c_probe(struct platform_device *pdev) 
	i2c_set_adapdata(&priv->adap, priv);

	ret = i2c_add_numbered_adapter(&priv->adap);

	if (ret < 0)

		return ret;

		goto err_unprepare_clk;



	platform_set_drvdata(pdev, priv);

	dev_info(&priv->adap.dev, "Added I2C Bus.\n");

	return 0;



err_unprepare_clk:

	clk_unprepare(clk);

	return ret;

}



static int xlr_i2c_remove(struct platform_device *pdev)