Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 716dd373 authored by Matt Ranostay's avatar Matt Ranostay Committed by Greg Kroah-Hartman
Browse files

iio: proximity: as3935: fix iio_trigger_poll issue 



commit 9122b54f266ddee09654fe3fbc503c1a60f4a01c upstream.

Using iio_trigger_poll() can oops when multiple interrupts
happen before the first is handled.

Use iio_trigger_poll_chained() instead and use the timestamp
when processed, since it will be in theory be 2 ms max latency.

Fixes: 24ddb0e4 ("iio: Add AS3935 lightning sensor support")
Signed-off-by: default avatarMatt Ranostay <matt.ranostay@konsulko.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bad3b49b

drivers/iio/proximity/as3935.c

+2 −2
Original line number Diff line number Diff line
@@ -215,7 +215,7 @@ static irqreturn_t as3935_trigger_handler(int irq, void *private) 


	st->buffer[0] = val & AS3935_DATA_MASK;

	iio_push_to_buffers_with_timestamp(indio_dev, &st->buffer,

					   pf->timestamp);

					   iio_get_time_ns(indio_dev));

err_read:

	iio_trigger_notify_done(indio_dev->trig);
@@ -244,7 +244,7 @@ static void as3935_event_work(struct work_struct *work) 


	switch (val) {

	case AS3935_EVENT_INT:

		iio_trigger_poll(st->trig);

		iio_trigger_poll_chained(st->trig);

		break;

	case AS3935_NOISE_INT:

		dev_warn(&st->spi->dev, "noise level is too high\n");