Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7085e056 authored by Mukesh Ojha's avatar Mukesh Ojha
Browse files

soc: qcom: dcc: Use sscanf instead of strlcpy 



When we write string on sysfs node it appends '\n' at the end which
modifies passed string. 'strlcpy' does not take care of removing '\n'
so use sscanf which truncate '\n' from the original string.

Change-Id: Id99124f380ad4dc3c9c0ffcaee045304f131844e
CRs-Fixed: 2193257
Signed-off-by: default avatarMukesh Ojha <mojha@codeaurora.org>
parent 901d889a

drivers/soc/qcom/dcc.c

+5 −3
Original line number Diff line number Diff line 
/* Copyright (c) 2015-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -554,7 +554,8 @@ static ssize_t dcc_store_func_type(struct device *dev, 
	if (strlen(buf) >= 10)

		return -EINVAL;



	strlcpy(str, buf, sizeof(str));

	if (sscanf(buf, "%9s", str) != 1)

		return -EINVAL;



	mutex_lock(&drvdata->mutex);

	if (drvdata->enable) {
@@ -599,7 +600,8 @@ static ssize_t dcc_store_data_sink(struct device *dev, 
	if (strlen(buf) >= 10)

		return -EINVAL;



	strlcpy(str, buf, sizeof(str));

	if (sscanf(buf, "%9s", str) != 1)

		return -EINVAL;



	mutex_lock(&drvdata->mutex);

	if (drvdata->enable) {