Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7061f39e authored by Eric Sandeen's avatar Eric Sandeen Committed by Prashantsinh Parmar
Browse files

seq_file: disallow extremely large seq buffer allocations 



commit 8cae8cd89f05f6de223d63e6d15e31c8ba9cf53b upstream.

There is no reasonable need for a buffer larger than this, and it avoids
int overflow pitfalls.

Fixes: 058504ed ("fs/seq_file: fallback to vmalloc allocation")
Issue: FP3SEC-160
Change-Id: I9146bf107c54eec606b5ce468e22d47674ddf14e
Suggested-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Reported-by: default avatarQualys Security Advisory <qsa@qualys.com>
Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 82280f83)
parent 1e533301

fs/seq_file.c

+3 −0
Original line number Diff line number Diff line
@@ -28,6 +28,9 @@ static void *seq_buf_alloc(unsigned long size) 
	void *buf;

	gfp_t gfp = GFP_KERNEL;



	if (unlikely(size > MAX_RW_COUNT))

		return NULL;



	/*

	 * For high order allocations, use __GFP_NORETRY to avoid oom-killing -

	 * it's better to fall back to vmalloc() than to kill things.  For small