Commit 7024cc88 authored Apr 20, 2016 by H Hartley Sweeten Committed by Greg Kroah-Hartman Apr 28, 2016

staging: comedi: mite: remove BUG_ON() in MITE_IODWBSR_1_WSIZE_bits()



Prior to calling this function pci_ioremap_bar() is called. If the
pci_resource_len(), i.e. the 'size', was 0 the ioremap would fail
so this function would never be called. So the first BUG_ON() can
never occur.

The 'order' returned by ilog2() will always be > 0 so the second
BUG_ON() will also never occur.

Remove the unnecessary BUG_ON() checks and tidy up the function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 43d66724

drivers/staging/comedi/drivers/mite.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -157,12 +157,7 @@

		static unsigned int MITE_IODWBSR_1_WSIZE_bits(unsigned int size)
		{
		unsigned int order = 0;

		BUG_ON(size == 0);
		order = ilog2(size);
		BUG_ON(order < 1);
		return (order - 1) & 0x1f;
		return (ilog2(size) - 1) & 0x1f;
		}

		static unsigned int mite_retry_limit(unsigned int retry_limit)