Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ff730c3 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Paul Mackerras
Browse files

[PATCH] spufs: fix sparse warnings 



One local variable is missing an __iomem modifier,
in another place, we pass a completely unused argument
with a missing __user modifier.

Signed-off-by: default avatarArnd Bergmann <arndb@de.ibm.com>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent f0831acc

arch/powerpc/platforms/cell/spu_base.c

+1 −1
Original line number Diff line number Diff line
@@ -357,7 +357,7 @@ static void spu_init_channels(struct spu *spu) 
		{ 0x17, 1, }, { 0x18, 0, }, { 0x19, 0, }, { 0x1b, 0, },

		{ 0x1c, 1, }, { 0x1d, 0, }, { 0x1e, 1, },

	};

	struct spu_priv2 *priv2;

	struct spu_priv2 __iomem *priv2;

	int i;



	priv2 = spu->priv2;

arch/powerpc/platforms/cell/spufs/inode.c

+2 −3
Original line number Diff line number Diff line
@@ -293,8 +293,7 @@ static int spufs_context_open(struct dentry *dentry, struct vfsmount *mnt) 


static struct file_system_type spufs_type;



long

spufs_create_thread(struct nameidata *nd, const char *name,

long spufs_create_thread(struct nameidata *nd,

			 unsigned int flags, mode_t mode)

{

	struct dentry *dentry;

arch/powerpc/platforms/cell/spufs/spufs.h

+1 −1
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ extern struct tree_descr spufs_dir_contents[]; 
/* system call implementation */

long spufs_run_spu(struct file *file,

		   struct spu_context *ctx, u32 *npc, u32 *status);

long spufs_create_thread(struct nameidata *nd, const char *name,

long spufs_create_thread(struct nameidata *nd,

			 unsigned int flags, mode_t mode);

extern struct file_operations spufs_context_fops;

arch/powerpc/platforms/cell/spufs/syscalls.c

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ asmlinkage long sys_spu_create(const char __user *pathname, 
		ret = path_lookup(tmp, LOOKUP_PARENT|

				LOOKUP_OPEN|LOOKUP_CREATE, &nd);

		if (!ret) {

			ret = spufs_create_thread(&nd, pathname, flags, mode);

			ret = spufs_create_thread(&nd, flags, mode);

			path_release(&nd);

		}

		putname(tmp);