Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f3f1fab authored by Arun Kumar Neelakantam's avatar Arun Kumar Neelakantam
Browse files

net: ipc_router: Initialize the sockaddr in recvmsg() handler 



sockaddr structure is filled with required information only which
results in few memory locations of structure with uninitialized data.

Memset complete structure before using it to remove uninitialized data.

CRs-Fixed: 2274853
Change-Id: I181710bde100fb1553b925d9fdf227af35ff38b5
Signed-off-by: default avatarArun Kumar Neelakantam <aneela@codeaurora.org>
parent 7af3eef5

net/ipc_router/ipc_router_socket.c

+3 −1
Original line number Diff line number Diff line 
/* Copyright (c) 2011-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2011-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -146,6 +146,7 @@ static int msm_ipc_router_extract_msg(struct msghdr *m, 
			return -EINVAL;

		}

		ctl_msg = (union rr_control_msg *)(temp->data);

		memset(addr, 0x0, sizeof(*addr));

		addr->family = AF_MSM_IPC;

		addr->address.addrtype = MSM_IPC_ADDR_ID;

		addr->address.addr.port_addr.node_id = ctl_msg->cli.node_id;
@@ -154,6 +155,7 @@ static int msm_ipc_router_extract_msg(struct msghdr *m, 
		return offset;

	}

	if (addr && (hdr->type == IPC_ROUTER_CTRL_CMD_DATA)) {

		memset(addr, 0x0, sizeof(*addr));

		addr->family = AF_MSM_IPC;

		addr->address.addrtype = MSM_IPC_ADDR_ID;

		addr->address.addr.port_addr.node_id = hdr->src_node_id;