Commit 6e51f9cb authored Jun 15, 2014 by Namhyung Kim Committed by Paul Moore Jun 19, 2014

selinux: fix a possible memory leak in cond_read_node()



The cond_read_node() should free the given node on error path as it's
not linked to p->cond_list yet.  This is done via cond_node_destroy()
but it's not called when next_entry() fails before the expr loop.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Paul Moore <pmoore@redhat.com>

parent f004afe6

security/selinux/ss/conditional.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -404,7 +404,7 @@ static int cond_read_node(struct policydb p, struct cond_node node, void *fp)

		rc = next_entry(buf, fp, sizeof(u32) * 2);
		if (rc)
		return rc;
		goto err;

		node->cur_state = le32_to_cpu(buf[0]);