Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e470d26 authored by Hannes Eder's avatar Hannes Eder Committed by David S. Miller
Browse files

drivers/net/skfp: fix sparse warning: Should it be static? 



Impact: Move function declarations to header file.

Fix this sparse warnings:
  drivers/net/skfp/cfm.c:146:6: warning: symbol 'all_selection_criteria' was not declared. Should it be static?
  drivers/net/skfp/drvfbi.c:186:6: warning: symbol 'mac1_irq' was not declared. Should it be static?
  drivers/net/skfp/drvfbi.c:284:6: warning: symbol 'read_address' was not declared. Should it be static?
  drivers/net/skfp/drvfbi.c:323:6: warning: symbol 'init_board' was not declared. Should it be static?
  drivers/net/skfp/fplustm.c:72:24: warning: symbol 'fddi_broadcast' was not declared. Should it be static?
  drivers/net/skfp/fplustm.c:679:6: warning: symbol 'mac2_irq' was not declared. Should it be static?
  drivers/net/skfp/fplustm.c:805:6: warning: symbol 'mac3_irq' was not declared. Should it be static?
  drivers/net/skfp/fplustm.c:856:5: warning: symbol 'init_fplus' was not declared. Should it be static?
  drivers/net/skfp/pcmplc.c:404:6: warning: symbol 'init_plc' was not declared. Should it be static?
  drivers/net/skfp/pcmplc.c:1592:5: warning: symbol 'pcm_status_twisted' was not declared. Should it be static?
  drivers/net/skfp/smtinit.c:68:5: warning: symbol 'init_smt' was not declared. Should it be static?

Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 37d37695

drivers/net/skfp/h/smc.h

+17 −0
Original line number Diff line number Diff line
@@ -467,5 +467,22 @@ struct s_smc { 
#endif	/* DEBUG_BRD && DEBUG */

} ;



extern const struct fddi_addr fddi_broadcast;



extern void all_selection_criteria(struct s_smc *smc);

extern void card_stop(struct s_smc *smc);

extern void init_board(struct s_smc *smc, u_char *mac_addr);

extern int init_fplus(struct s_smc *smc);

extern void init_plc(struct s_smc *smc);

extern int init_smt(struct s_smc *smc, u_char * mac_addr);

extern void mac1_irq(struct s_smc *smc, u_short stu, u_short stl);

extern void mac2_irq(struct s_smc *smc, u_short code_s2u, u_short code_s2l);

extern void mac3_irq(struct s_smc *smc, u_short code_s3u, u_short code_s3l);

extern int pcm_status_twisted(struct s_smc *smc);

extern void plc1_irq(struct s_smc *smc);

extern void plc2_irq(struct s_smc *smc);

extern void read_address(struct s_smc *smc, u_char * mac_addr);

extern void timer_irq(struct s_smc *smc);



#endif	/* _SCMECM_ */

drivers/net/skfp/hwmtm.c

+0 −9
Original line number Diff line number Diff line
@@ -97,23 +97,15 @@ static void mac_drv_clear_txd(struct s_smc *smc); 


extern void* mac_drv_get_space(struct s_smc *smc, unsigned int size);

extern void* mac_drv_get_desc_mem(struct s_smc *smc, unsigned int size);

extern void init_board(struct s_smc *smc, u_char *mac_addr);

extern void mac_drv_fill_rxd(struct s_smc *smc);

extern void plc1_irq(struct s_smc *smc);

extern void mac_drv_tx_complete(struct s_smc *smc,

				volatile struct s_smt_fp_txd *txd);

extern void plc2_irq(struct s_smc *smc);

extern void mac1_irq(struct s_smc *smc, u_short stu, u_short stl);

extern void mac2_irq(struct s_smc *smc, u_short code_s2u, u_short code_s2l);

extern void mac3_irq(struct s_smc *smc, u_short code_s3u, u_short code_s3l);

extern void timer_irq(struct s_smc *smc);

extern void mac_drv_rx_complete(struct s_smc *smc,

				volatile struct s_smt_fp_rxd *rxd,

				int frag_count, int len);

extern void mac_drv_requeue_rxd(struct s_smc *smc, 

				volatile struct s_smt_fp_rxd *rxd,

				int frag_count);

extern void init_plc(struct s_smc *smc);

extern void mac_drv_clear_rxd(struct s_smc *smc,

			      volatile struct s_smt_fp_rxd *rxd, int frag_count);
@@ -136,7 +128,6 @@ extern void dma_complete(struct s_smc *smc, volatile union s_fp_descr *descr, 
			 int flag);

#endif



extern int init_fplus(struct s_smc *smc);

extern int mac_drv_rx_init(struct s_smc *smc, int len, int fc, char *look_ahead,

			   int la_len);

drivers/net/skfp/pcmplc.c

+0 −3
Original line number Diff line number Diff line
@@ -198,9 +198,6 @@ static int plc_imsk_na = PL_PCM_CODE | PL_TRACE_PROP | PL_PCM_BREAK | 
static const int plc_imsk_act = PL_PCM_CODE | PL_TRACE_PROP | PL_PCM_BREAK |

			PL_PCM_ENABLED | PL_SELF_TEST | PL_EBUF_ERR;



/* external functions */

void all_selection_criteria(struct s_smc *smc);



/* internal functions */

static void pcm_fsm(struct s_smc *smc, struct s_phy *phy, int cmd);

static void pc_rcode_actions(struct s_smc *smc, int bit, struct s_phy *phy);

drivers/net/skfp/skfddi.c

+0 −3
Original line number Diff line number Diff line
@@ -135,14 +135,11 @@ void dump_data(unsigned char *Data, int length); 


// External functions from the hardware module

extern u_int mac_drv_check_space(void);

extern void read_address(struct s_smc *smc, u_char * mac_addr);

extern void card_stop(struct s_smc *smc);

extern int mac_drv_init(struct s_smc *smc);

extern void hwm_tx_frag(struct s_smc *smc, char far * virt, u_long phys,

			int len, int frame_status);

extern int hwm_tx_init(struct s_smc *smc, u_char fc, int frag_count,

		       int frame_len, int frame_status);

extern int init_smt(struct s_smc *smc, u_char * mac_addr);

extern void fddi_isr(struct s_smc *smc);

extern void hwm_rx_frag(struct s_smc *smc, char far * virt, u_long phys,

			int len, int frame_status);

drivers/net/skfp/smt.c

+0 −10
Original line number Diff line number Diff line
@@ -54,16 +54,6 @@ static const struct fddi_addr SMT_Unknown = { 
	{ 0,0,0x1f,0,0,0 }

} ;



/*

 * external variables

 */

extern const struct fddi_addr fddi_broadcast ;



/*

 * external functions

 */

int pcm_status_twisted(struct s_smc *smc);



/*

 * function prototypes

 */