Commit 6d556294 authored May 24, 2010 by Bob Liu Committed by Linus Torvalds May 25, 2010

mempolicy: remove redundant code



1.  In funtion is_valid_nodemask(), varibable k will be inited to 0 in
   the following loop, needn't init to policy_zone anymore.

2. (MPOL_F_STATIC_NODES | MPOL_F_RELATIVE_NODES) has already defined
   to MPOL_MODE_FLAGS in mempolicy.h.

Signed-off-by: Bob Liu <lliubbo@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e13861d8

mm/mempolicy.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -127,9 +127,6 @@ static int is_valid_nodemask(const nodemask_t *nodemask)
		{
		int nd, k;

		/* Check that there is something useful in this mask */
		k = policy_zone;

		for_each_node_mask(nd, *nodemask) {
		struct zone *z;

		@@ -145,7 +142,7 @@ static int is_valid_nodemask(const nodemask_t *nodemask)

		static inline int mpol_store_user_nodemask(const struct mempolicy *pol)
		{
		return pol->flags & (MPOL_F_STATIC_NODES \| MPOL_F_RELATIVE_NODES);
		return pol->flags & MPOL_MODE_FLAGS;
		}

		static void mpol_relative_nodemask(nodemask_t ret, const nodemask_t orig,