Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d4d4554 authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by Greg Kroah-Hartman
Browse files

USB: iowarrior: fix misuse of return value of copy_to_user() 



copy_to_user() returns number of not copied bytes, not error code.

Signed-off-by: default avatarKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 14184f9b

drivers/usb/misc/iowarrior.c

+2 −2
Original line number Diff line number Diff line
@@ -542,7 +542,7 @@ static long iowarrior_ioctl(struct file *file, unsigned int cmd, 
			retval = io_res;

		else {

			io_res = copy_to_user(user_buffer, buffer, dev->report_size);

			if (io_res < 0)

			if (io_res)

				retval = -EFAULT;

		}

		break;
@@ -574,7 +574,7 @@ static long iowarrior_ioctl(struct file *file, unsigned int cmd, 
			}

			io_res = copy_to_user((struct iowarrior_info __user *)arg, &info,

					 sizeof(struct iowarrior_info));

			if (io_res < 0)

			if (io_res)

				retval = -EFAULT;

			break;

		}